[JENKINS-69573] retrieve sources in tmpdir and rename#58
Open
mawinter69 wants to merge 2 commits intojenkinsci:masterfrom
Open
[JENKINS-69573] retrieve sources in tmpdir and rename#58mawinter69 wants to merge 2 commits intojenkinsci:masterfrom
mawinter69 wants to merge 2 commits intojenkinsci:masterfrom
Conversation
In case the retrieve of the library sources from the scm fails, we end up with a corrupted cache directory that is only cleaned when the cache expires. To avoid this fetch the sources into a tmp directory and rename to the actual cache dir once completed.
Member
rsandell
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the retrieve from the scm of a library into the cache fails, we end up with a corrupted cache directory. All following pipelines using this library will fail until the cache has expired.
This fix will create a temporary directory into which the library is retrieved. Afterwards the directory is renamed to the actual cache directory (which is more or less atomic).
JENKINS-69573